Allow Consuming Tags in the Apply Rules Tool #6545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop use of startsWith in favor of indexOf for PhantomJS testing.
This should allow nesting and filtering from tags - including group tags.
Should make it a lot easier to nested and filter on group tag values.
jmchilton
force-pushed
the
rule_builder_use_group_tags
branch
from
22d6a52 to
5807230
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small polish, bug fix commits and then two primary commits to allow using tags more effectively in the Apply Rules tool.
The previously merged PR #6500 allowed setting tags from metadata when importing new collections using the rule builder. 4d83746 included in this PR then lets dataset tags already present to be loaded in when modifying the collection with the "Apply Rules" tool (added in 18.05 as part of #5819). This allows filtering a collection based on tags and re-organizing the nesting structure of a collection based on tags.
18.09 will introduce a new kind of tags - group tags (added in #6491) that like name tags will be auto-propagated but won't be used for naming but instead of categorizing datasets in a factorial analysis. #6500 added support for populating datasets with such tags when importing them using the rule builder and #5457 will add support for tools to effectively consume these group tags. 5807230 included in this PR now lets the user very easily use these tags with the "Apply Rules" tool. This allows certain kinds of filtering and re-organization using group tags specifically that are technically possible after the previous commit be implemented by users in one step instead of several. For instance, if datasets in a collection have different group tags such as
group:type:singleandgroup:type:paired-end- a single rule can now be used to populate a column containing eithersingleorpaired-end. This will likely be the most common tagging operation with the Apply Rules tool and would require 3 rules without this change.